This repository was archived by the owner on Jan 5, 2023. It is now read-only.
Refactor ReturnValue[n] in data flow libraries
#673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-mc
force-pushed
the
refactor-returnvalue-n
branch
from
93f3149 to
44641de
Compare
owen-mc
changed the title
ReturnValue[n]ReturnValue[n] in data flow libraries
Contributor
Author
|
To be clear, this undoes edits to |
smowton
approved these changes
Jan 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way that
ReturnValue[n]was supported in #574 involved editing some files that will be overwritten when the data flow libraries are next synced. We move this code fromFlowSummaryImpl.qllintoFlowSummaryImplSpecific.qllto avoid this problem.We also add special treatment of
ReturnValue[n]in one place where it was missing.