Skip to content
This repository was archived by the owner on Jan 5, 2023. It is now read-only.

Recognise more testing frameworks#94

Merged
max-schaefer merged 5 commits intogithub:masterfrom
max-schaefer:more-testing-frameworks
Apr 9, 2020
Merged

Recognise more testing frameworks#94
max-schaefer merged 5 commits intogithub:masterfrom
max-schaefer:more-testing-frameworks

Conversation

@max-schaefer
Copy link
Copy Markdown
Contributor

I've only added tests for one of them, which is part of the standard library. The others might be good test cases for the stubber.

@max-schaefer max-schaefer added this to the 1.24 milestone Apr 9, 2020
@max-schaefer max-schaefer requested a review from sauyon April 9, 2020 08:43
Copy link
Copy Markdown
Contributor

@sauyon sauyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should I try adding tests using the stubber in a different PR?

@max-schaefer
Copy link
Copy Markdown
Contributor Author

Should I try adding tests using the stubber in a different PR?

Yes, please, but that doesn't need to go into 1.24.

@max-schaefer max-schaefer merged commit cf8eff5 into github:master Apr 9, 2020
@intrigus-lgtm
Copy link
Copy Markdown
Contributor

What's "the stubber"?

@max-schaefer
Copy link
Copy Markdown
Contributor Author

It's something @sauyon has been working on; watch this space.

@intrigus-lgtm
Copy link
Copy Markdown
Contributor

Well I guess then I don't have to try to write one :)
Maybe I'll write one anyway to learn more Go :D

@max-schaefer max-schaefer deleted the more-testing-frameworks branch April 14, 2020 10:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants