Skip to content

Align ESLint dependencies on v10 - #1456

Closed
henrymercer wants to merge 1 commit into
mainfrom
henrymercer/eslint-10-alignment
Closed

Align ESLint dependencies on v10#1456
henrymercer wants to merge 1 commit into
mainfrom
henrymercer/eslint-10-alignment

Conversation

@henrymercer

Copy link
Copy Markdown
Contributor

Summary

  • upgrade eslint from 9.39.5 to 10.8.0
  • align the declared @typescript-eslint/parser minimum with the already-resolved ESLint 10-compatible 8.65.0 release
  • regenerate package-lock.json from a clean install

Context

The manifest previously combined @eslint/js@^10.0.1, whose peer dependency requires ESLint 10, with eslint@^9.39.5. The committed lockfile preserved that mismatched graph, so npm ci worked, but npm could not regenerate the lockfile from the manifest.

ESLint 10 was previously postponed because eslint-plugin-github only supported ESLint 9. That blocker is resolved: eslint-plugin-github supports ESLint 10 as of 6.1.0, and this repository already uses ^6.1.1.

Dependabot is currently configured to ignore the ESLint 10.x major after the earlier postponement. Someone may want to lift that ignore after this merges so future ESLint 10.x updates flow normally; this PR intentionally does not change Dependabot configuration.

Validation

  • npm ci
  • npm run lint
  • .github/workflows/script/check-js.sh
  • .github/workflows/script/check-json-schemas.sh
  • npm run find-deadcode
  • npm test

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@henrymercer
henrymercer requested a review from a team as a code owner August 4, 2026 13:16
Copilot AI balanced review requested due to automatic review settings August 4, 2026 13:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns ESLint tooling on compatible v10 releases and restores reproducible dependency installation.

Changes:

  • Upgrades ESLint to 10.8.0.
  • Aligns the TypeScript ESLint parser with 8.65.0.
  • Regenerates and deduplicates the lockfile.
Show a summary per file
File Description
package.json Updates ESLint and parser requirements.
package-lock.json Records the regenerated ESLint 10-compatible dependency graph.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/2 changed files
  • Comments generated: 0
  • Review effort level: Balanced

@henrymercer henrymercer closed this Aug 4, 2026
@oscarsj

oscarsj commented Aug 4, 2026

Copy link
Copy Markdown
Member

@henrymercer what happened here?

@henrymercer

Copy link
Copy Markdown
Contributor Author

eslint-plugin-github supports eslint v10 on its own, but it also pulls in eslint-plugin-import@2.32.0 and eslint-plugin-jsx-a11y@6.10.2 which don't support eslint v10. The linting passes, but it's not supported and we'll get peer dependency warnings in our builds, so I suggest we stick with v9 for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants