Skip to content

C++: Prepare Buffer.qll for IR-based use-use dataflow#10833

Merged
MathiasVP merged 4 commits intogithub:mathiasvp/replace-ast-with-ir-use-usedataflowfrom
MathiasVP:repair-badly-bounded-write-2
Oct 26, 2022
Merged

C++: Prepare Buffer.qll for IR-based use-use dataflow#10833
MathiasVP merged 4 commits intogithub:mathiasvp/replace-ast-with-ir-use-usedataflowfrom
MathiasVP:repair-badly-bounded-write-2

Conversation

@MathiasVP
Copy link
Copy Markdown
Contributor

This PR prepares the Buffer.qll library for the IR-based use-use dataflow-library. There are a couple of new FPs that we didn't get prior to the dataflow change, but this is because we now have better dataflow.

@MathiasVP MathiasVP requested a review from a team as a code owner October 14, 2022 10:38
@github-actions github-actions Bot added the C++ label Oct 14, 2022
@MathiasVP MathiasVP added the no-change-note-required This PR does not need a change note label Oct 14, 2022
Comment thread cpp/ql/lib/semmle/code/cpp/commons/Buffer.qll Outdated
rdmarsh2
rdmarsh2 previously approved these changes Oct 17, 2022
tranphuoc1995 referenced this pull request Oct 18, 2022
Tests can be run with
```
bazel test //swift/codegen:tests
```

Coverage can be checked installing `pytest-cov` and running
```
pytest --cov=swift/codegen swift/codegen/test
```
@rdmarsh2 rdmarsh2 self-requested a review October 18, 2022 14:29
@rdmarsh2 rdmarsh2 dismissed their stale review October 18, 2022 14:30

Duplicated n.asIndirectArgument()

@MathiasVP MathiasVP merged commit 4bcba16 into github:mathiasvp/replace-ast-with-ir-use-usedataflow Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C++ no-change-note-required This PR does not need a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants