C++: Fix asExpr and asIndirectExpr in IR dataflow#10995
Merged
jketema merged 7 commits intogithub:mathiasvp/replace-ast-with-ir-use-usedataflowfrom Oct 28, 2022
Merged
C++: Fix asExpr and asIndirectExpr in IR dataflow#10995jketema merged 7 commits intogithub:mathiasvp/replace-ast-with-ir-use-usedataflowfrom
asExpr and asIndirectExpr in IR dataflow#10995jketema merged 7 commits intogithub:mathiasvp/replace-ast-with-ir-use-usedataflowfrom
Conversation
…' to structure conversions between indirect daaflow nodes and expressions.
…bleAddressInstruction'.
MathiasVP
force-pushed
the
fix-as-expr
branch
from
460fefc to
2fc7e61
Compare
jketema
reviewed
Oct 27, 2022
jketema
approved these changes
Oct 27, 2022
Contributor
jketema
left a comment
jketema
left a comment
There was a problem hiding this comment.
Given what we discussed f2f and my current knowledge of this, this looks sensible.
Contributor
Author
|
Merge conflicts fixed. They were as simple as accepting both changes 🎉. |
jketema
merged commit fafc0b5
into
github:mathiasvp/replace-ast-with-ir-use-usedataflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains my ongoing progress on fixing some of the issues I encountered with @jketema while we were trying to fixup the
cpp/non-constant-formatquery in preparation for use-use dataflow.I'm still not super happy with the PR. I think there are some nodes that we want to have aThis has been fixed in e2a0d62.asExprresult for, but which currently don't have a result because.getConvertedResultExpression()doesn't have a result for some of the instruction nodes we care about (for instance,VariableAddressInstructions).