C++: Fix the use-use dataflow configuration in dataflow/dataflow-tests#11147
Merged
MathiasVP merged 1 commit intogithub:mathiasvp/replace-ast-with-ir-use-usedataflowfrom Nov 7, 2022
Conversation
MathiasVP
merged commit b305e15
into
github:mathiasvp/replace-ast-with-ir-use-usedataflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remaining cases where IR use-use dataflow seems to perform worse than AST dataflow:
codeql/cpp/ql/test/library-tests/dataflow/dataflow-tests/ref.cpp
Line 59 in 89c5e3d
codeql/cpp/ql/test/library-tests/dataflow/dataflow-tests/ref.cpp
Line 65 in 89c5e3d
codeql/cpp/ql/test/library-tests/dataflow/dataflow-tests/test.cpp
Line 92 in 89c5e3d
codeql/cpp/ql/test/library-tests/dataflow/dataflow-tests/true_upon_entry.cpp
Line 13 in 89c5e3d
codeql/cpp/ql/test/library-tests/dataflow/dataflow-tests/true_upon_entry.cpp
Line 66 in 89c5e3d
Inconsistent behaviour for flow through global variables:
codeql/cpp/ql/test/library-tests/dataflow/dataflow-tests/test.cpp
Line 349 in 89c5e3d
Broken barrier guard:
codeql/cpp/ql/test/library-tests/dataflow/dataflow-tests/BarrierGuard.cpp
Line 7 in 89c5e3d
codeql/cpp/ql/test/library-tests/dataflow/dataflow-tests/BarrierGuard.cpp
Line 17 in 89c5e3d
codeql/cpp/ql/test/library-tests/dataflow/dataflow-tests/BarrierGuard.cpp
Line 23 in 89c5e3d
codeql/cpp/ql/test/library-tests/dataflow/dataflow-tests/BarrierGuard.cpp
Line 41 in 89c5e3d