TS: allow namespace imports as types#1138
Merged
semmle-qlci merged 4 commits intogithub:rc/1.20from Mar 21, 2019
Merged
Conversation
xiemaisi
suggested changes
Mar 20, 2019
xiemaisi
left a comment
xiemaisi
left a comment
There was a problem hiding this comment.
Basically LGTM. Slightly adventurous as a hotfix, but I trust you have thought about the benefits and risks involved.
| locations_default(#20002,#10000,1,1,1,1) | ||
| hasLocation(#20001,#20002) | ||
| #20003=* | ||
| jsParseErrors(#20003,#20001,"Error: Unexpected token"," yield import(""foo"") |
There was a problem hiding this comment.
This doesn't look right; that syntax error shouldn't be there on the rc.
Contributor
Author
There was a problem hiding this comment.
Sigh. That was a case of Eclipse needing a refresh
|
Can you check if it solves this https://jira.semmle.com/browse/ODASA-7792 issue as well? |
Contributor
Author
That was fixed previosly. I've closed the issue. |
xiemaisi
previously approved these changes
Mar 20, 2019
xiemaisi
approved these changes
Mar 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently I was very careful to not allow namespaces to be seen as types, but apparently now they can. Fixes some FPs reported by our unused import query.