C++: Better caching for IR-based use-use dataflow#11645
Merged
MathiasVP merged 2 commits intogithub:mathiasvp/replace-ast-with-ir-use-usedataflowfrom Dec 10, 2022
Merged
C++: Better caching for IR-based use-use dataflow#11645MathiasVP merged 2 commits intogithub:mathiasvp/replace-ast-with-ir-use-usedataflowfrom
MathiasVP merged 2 commits intogithub:mathiasvp/replace-ast-with-ir-use-usedataflowfrom
Conversation
jketema
approved these changes
Dec 10, 2022
Contributor
jketema
left a comment
jketema
left a comment
There was a problem hiding this comment.
That diff was very hard to read, but LGTM.
Contributor
Author
Yeah, sorry :( it's really just moving things into a cached module, but I do see that the diff is making this rather difficult to spot! |
MathiasVP
merged commit 9e7b73a
into
github:mathiasvp/replace-ast-with-ir-use-usedataflow
Contributor
Yup, that was also my conclusion. |
Contributor
|
Unless you invoke |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out the
simpleLocalFlowSteprelation wasn't cached 😱. This PR fixes this.