C++: allow read steps at the sink in IR taint test#12079
Merged
MathiasVP merged 2 commits intogithub:mathiasvp/replace-ast-with-ir-use-usedataflowfrom Feb 8, 2023
Merged
Conversation
rdmarsh2
force-pushed
the
rdmarsh2/use-use-taint-test-reads
branch
from
f7c7c2d to
ad8e82a
Compare
MathiasVP
reviewed
Feb 3, 2023
Contributor
The single-field struct thing was really only there to work-around the fact that writes to a single-field struct didn't generate So I like the solution in this PR a lot more! |
Contributor
MathiasVP
merged commit 946e301
into
github:mathiasvp/replace-ast-with-ir-use-usedataflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves a few missing taint sinks, but I'm not sure if they were testing special handling for single-field structs before. @MathiasVP IIRC you did something special for single-field structs when adding field flow into the def-use IR dataflow, should we reimplement that instead of adding this case?