CPP: Fix FormatLiteral.isMicrosoft#1219
Merged
jbj merged 2 commits intogithub:masterfrom May 13, 2019
Merged
Conversation
Contributor
|
@geoffw0 The test job failed. |
Contributor
Author
|
redo failed |
Contributor
Author
|
I've now added a submodule update to https://git.semmle.com/Semmle/code/pull/31505, the test should pass there. |
jbj
added
the
depends on internal PR
Contributor
|
Okay. I'd expected the tests to pass because there was no "depends on internal PR" label on this PR. |
geoffw0
force-pushed
the
msfix2
branch
3 times, most recently
from
0820959 to
15090ef
Compare
jbj
previously approved these changes
May 8, 2019
jbj
approved these changes
May 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out
File.compiledAsMicrosoft()is missing a lot of Microsoft compiled files that are built withextractor.exe --mimic @-. As a quick fix, have the string formatting functions look for any Microsoft compiled file in the snapshot (i.e. assume a mix of compilers is not being used). This should produce good reliability in practice.