JavaScript: Teach AutoBuilder to extract YAML files by default.#1235
Merged
1 commit merged intogithub:masterfrom Apr 11, 2019
Merged
JavaScript: Teach AutoBuilder to extract YAML files by default.#12351 commit merged intogithub:masterfrom
1 commit merged intogithub:masterfrom
Conversation
ghost
approved these changes
Apr 11, 2019
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our default benchmark projects only contain a little more than 200 KLoC of YAML overall, so it seems pretty safe to just extract it all by default. (For comparison, there are over 4.6 MLoC of JSON in the same projects.)
This won't affect our default analysis very much, but could be useful for custom queries.
I've added a change note and will file an issue ticket to update the LGTM documentation once this is merged.