JavaScript: Generalise ConstantComparison sanitisers.#1278
Merged
asger-semmle merged 1 commit intogithub:masterfrom Apr 25, 2019
Merged
JavaScript: Generalise ConstantComparison sanitisers.#1278asger-semmle merged 1 commit intogithub:masterfrom
ConstantComparison sanitisers.#1278asger-semmle merged 1 commit intogithub:masterfrom
Conversation
asger-semmle
previously approved these changes
Apr 24, 2019
ghost
previously approved these changes
Apr 25, 2019
In addition to treating comparisons with literals as sanitisers, we now also treat comparisons with variables that have a single assignment as sanitisers. Proving that such a variable is actually a constant is not easy, but for this use case a simple approximation works fine.
xiemaisi
force-pushed
the
js/symbolic-constants
branch
from
82b3eaf to
a8470a9
Compare
Author
|
I've amended one expected test output. |
ghost
approved these changes
Apr 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to treating comparisons with literals as sanitisers, we now also treat comparisons with variables that have a single assignment as sanitisers.
Proving that such a variable is actually a constant is not easy, but for this use case a simple approximation works fine.
An evaluation of the security queries on big-apps (internal link) shows barely any performance changes, and a few false positives fixed on gecko-dev. I have verified that this PR also fixes two false positives on customer code which were the motivation for it.