Skip to content

JavaScript: Further broaden the whitelist in PasswordInConfigurationFile.#1314

Merged
asger-semmle merged 1 commit intogithub:masterfrom
xiemaisi:js/fix-hardcoded-pw-fps
May 16, 2019
Merged

JavaScript: Further broaden the whitelist in PasswordInConfigurationFile.#1314
asger-semmle merged 1 commit intogithub:masterfrom
xiemaisi:js/fix-hardcoded-pw-fps

Conversation

@xiemaisi
Copy link

@xiemaisi xiemaisi commented May 9, 2019

Fixes the FP reported here.

@xiemaisi xiemaisi added the JS label May 9, 2019
@xiemaisi xiemaisi requested a review from a team as a code owner May 9, 2019 16:08
Copy link

@gvarisco gvarisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gvarisco
Copy link

gvarisco commented May 9, 2019

Thanks for this, @xiemaisi :)

Copy link
Contributor

@asger-semmle asger-semmle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asger-semmle asger-semmle merged commit 65cbd47 into github:master May 16, 2019
@xiemaisi xiemaisi deleted the js/fix-hardcoded-pw-fps branch May 22, 2019 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments