JS: Fix some FPs in IncorrectSuffixCheck#1316
Merged
semmle-qlci merged 2 commits intogithub:masterfrom May 21, 2019
Merged
Conversation
ghost
suggested changes
May 14, 2019
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
This lacks a change note, otherwise LGTM.
I trust that the evaluation is uneventful.
asger-semmle
force-pushed
the
incorrect-suffix-check-fps
branch
from
f4dd70a to
b9ade67
Compare
xiemaisi
approved these changes
May 20, 2019
ghost
approved these changes
May 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The query looked for checks of form
index >= 0but not the negated version!(index < 0).