JavaScript: ECMAScript 2019 support.#1340
Merged
semmle-qlci merged 5 commits intogithub:masterfrom May 20, 2019
Merged
Conversation
added 5 commits
May 10, 2019 08:09
Also introduces an enum constant for ECMA 2020 (not used anywhere yet).
asger-semmle
approved these changes
May 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the last remaining ES2019 feature we didn't support yet, that is, JSON superset.
It also turns on support for ES2019 by default, and reclassifies optional catch binding as ES2019.
Evaluation is uneventful: a few fixed syntax errors in the babel test suites, but not performance regression.
The change to
version-compilers.csvis unrelated; I just happened to noticed this inconsistency.