Skip to content

ReDoS: stop spuriously matching everything when encountering an unsupported charclass#13468

Closed
erik-krogh wants to merge 2 commits intogithub:mainfrom
erik-krogh:redos-stop-unknown-charranges
Closed

ReDoS: stop spuriously matching everything when encountering an unsupported charclass#13468
erik-krogh wants to merge 2 commits intogithub:mainfrom
erik-krogh:redos-stop-unknown-charranges

Conversation

@erik-krogh
Copy link
Contributor

@erik-krogh erik-krogh commented Jun 15, 2023

Fixes a performance problem in Ruby.

@erik-krogh erik-krogh requested a review from aibaars June 15, 2023 10:49
@aibaars
Copy link
Contributor

aibaars commented Jun 15, 2023

@erik-krogh Could you target the rc/3.10 branch with this fix.

@erik-krogh
Copy link
Contributor Author

@erik-krogh Could you target the rc/3.10 branch with this fix.

I've done that as a separate PR: #13469

@calumgrant calumgrant requested a review from yoff June 19, 2023 09:14
@erik-krogh
Copy link
Contributor Author

@aibaars do you know when/if rc/3.10 is merged back into main?
I'm thinking if this PR should just be closed if rc/3.10 makes it into main soon.

@erik-krogh
Copy link
Contributor Author

This has been indirectly merged into main through the rc/3.10 branch - closing.

@erik-krogh erik-krogh closed this Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants