Conversation
This seems to have been missed in #1315.
Contributor
|
Good spot. Do we have a separate release branch (yet) this should target? |
Author
|
No; as per Slack, that branch will be created later today. |
jbj
approved these changes
Jun 3, 2019
Contributor
jbj
left a comment
jbj
left a comment
There was a problem hiding this comment.
Thanks! I merged the external PR with failing tests because the internal PR was passing its tests, including qhelp-preview. But it looks like the internal qhelp-preview job is only concerned with *.qhelp files in the internal repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to have been missed in #1315.