Java: Include two more base cases in TypeFlow to improve virtual dispatch.#1412
Merged
yh-semmle merged 1 commit intogithub:masterfrom Jun 10, 2019
Merged
Conversation
yh-semmle
approved these changes
Jun 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two more cases where type information is lost are added as base cases in TypeFlow. For
FunctionalExprthe type fromgetType()is based on the context, sogetConstructedType()is more precise and a place where type information is immediately discarded. Type information can also be lost in a step from a method to a call if the static dispatch target has a more general declared return type than the actually called method.The impact of this change is likely fairly minor (1348 removed tuples out of 4.8 million in the virtual dispatch relation on jdk9), but any precision improvement of virtual dispatch is a good thing.