Python: Fix getOperand for 'not' node and make sure it can only point-to a boolean. #1473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markshannon
force-pushed
the
python-points-to-more-unknowns
branch
2 times, most recently
from
5ab7117 to
fdf033a
Compare
markshannon
changed the title
Contributor
Author
|
The particular case this PR fixes is for
|
…nt-to a boolean.
markshannon
force-pushed
the
python-points-to-more-unknowns
branch
from
fdf033a to
5b145ed
Compare
taus-semmle
suggested changes
Jun 20, 2019
Contributor
taus-semmle
left a comment
taus-semmle
left a comment
There was a problem hiding this comment.
One question, otherwise LGTM.
| op instanceof USub and value = ObjectInternal::fromInt(-opvalue.intValue()) | ||
| or | ||
| opvalue = ObjectInternal::unknown() and value = opvalue | ||
| not op instanceof Not and opvalue = ObjectInternal::unknown() and value = opvalue |
Contributor
There was a problem hiding this comment.
Just to double-check, this extra condition is needed because ObjectInternal::unknown() has a booleanValue (in fact, it has both such values), and therefore without this instanceof check, we would have that a not of an unknown value was both True, False, and unknown.
I gather USub doesn't present a similar problem, because ObjectInternal::unknown() doesn't have an intValue.
Contributor
Author
There was a problem hiding this comment.
Yes, exactly. We want -unknown and ~unknown to be unknown, but not unknown to be True or False
taus-semmle
approved these changes
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.