Skip to content

Python: Don't report uninitialized locals in unreachable code.#1496

Merged
taus-semmle merged 1 commit intogithub:masterfrom
markshannon:python-uninitial-local-fix
Jun 27, 2019
Merged

Python: Don't report uninitialized locals in unreachable code.#1496
taus-semmle merged 1 commit intogithub:masterfrom
markshannon:python-uninitial-local-fix

Conversation

@markshannon
Copy link
Contributor

No tests as it is tricky to produce any error without the combination of library code (which is more often "unreachable" according to points-to) and loop unrolling.
This change cannot add any false positives and any potential additional false negatives should be in library code.

Copy link
Contributor

@taus-semmle taus-semmle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taus-semmle taus-semmle merged commit c0ff67b into github:master Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments