C++: fix FP with ExprHasNoEffect in defaulted func#1498
Merged
jbj merged 1 commit intogithub:masterfrom Jun 27, 2019
Merged
Conversation
Contributor
|
Tests failed. Is there a project on lgtm.com or a forum post that motivates this PR? |
This is a workaround for an extractor issue where expressions in a defaulted function are not always marked as generated. I haven't yet been able to reproduce the issue in a test case.
rdmarsh2
force-pushed
the
rdmarsh/exprHasNoEffect-defaulted-functions
branch
from
0eb706d to
8994a5a
Compare
Contributor
Author
|
Fixed the test failure. This should fix the FPs reported here. |
jbj
approved these changes
Jun 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a workaround for an extractor issue where expressions in a
defaulted function are not always marked as generated. I haven't yet been
able to reproduce the issue in a test case.