C#: Fix various extraction errors#1555
Merged
hvitved merged 9 commits intogithub:masterfrom Aug 30, 2019
Merged
Conversation
Contributor
|
The unit tests are failing, I will have a look once the PR is green. |
f7861ee to
d05e573
Compare
hvitved
reviewed
Aug 5, 2019
Contributor
hvitved
left a comment
There was a problem hiding this comment.
Two questions, otherwise LGTM.
d05e573 to
7d72923
Compare
Contributor
Author
|
Dist-compare results are as follows: |
84fa0fb to
4dd4167
Compare
hvitved
approved these changes
Aug 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix 3 classes of extraction error:
byte *[][]tripped up the typemention logic._as a regular variable name in aforeach, resulting in an unextracted local variable.nameof(System), whereSystemis a namespace resulted in an unknown identifier type.The last one required DB changes, because a
NameOfExprshould ideally have agetAccess(), which in turn means thatNamespaceshould be@accessibleand we needed a new type of expression,@namespace_access_exprto represent this access. This is not super important but may as well be done for completeness.