JavaScript: Add more default source nodes.#1561
Merged
semmle-qlci merged 2 commits intogithub:masterfrom Jul 8, 2019
Merged
Conversation
In particular, `await`, `yield` and dynamic `import` expressions are now source nodes, as well as a few other experimental and legacy language features involving non-local flow.
asger-semmle
reviewed
Jul 8, 2019
| * - import specifiers | ||
| * - function parameters | ||
| * - `this` nodes | ||
| * - `this` expressions |
Contributor
There was a problem hiding this comment.
ThisExpr is not a source node. Maybe say function receivers instead?
asger-semmle
approved these changes
Jul 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned by @asger-semmle on #1495,
awaitreally should be a source node. This PR makes it so, and also adds inyieldand dynamicimportexpressions as well as a few other experimental and legacy language features involving non-local flow.No changes (internal link), so no change note.