Skip to content

JS: Do not treat the empty string as a credential#1655

Merged
semmle-qlci merged 1 commit intogithub:masterfrom
asger-semmle:hardcoded-creds-fp
Jul 31, 2019
Merged

JS: Do not treat the empty string as a credential#1655
semmle-qlci merged 1 commit intogithub:masterfrom
asger-semmle:hardcoded-creds-fp

Conversation

@asger-semmle
Copy link
Contributor

Got a FP report about this so I'm proposing to stop treating empty strings as credentials.

@asger-semmle asger-semmle requested a review from a team as a code owner July 30, 2019 16:33
@ghost
Copy link

ghost commented Jul 31, 2019

FTR, I plan on merging and improving the blacklists of js/password-in-configuration-file and js/hardcoded-credentials soon.

@semmle-qlci semmle-qlci merged commit cff8262 into github:master Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments