JS: ignore mocked callees for js/superfluous-trailing-arguments#1668
Merged
semmle-qlci merged 1 commit intomasterfrom Aug 2, 2019
unknown repository
Merged
JS: ignore mocked callees for js/superfluous-trailing-arguments#1668semmle-qlci merged 1 commit intomasterfrom unknown repository
semmle-qlci merged 1 commit intomasterfrom
unknown repository
Conversation
|
I assume you have seen cases where the placeholder function doesn't just have a single |
Author
|
Good question. The motivating anomalies are long gone from memory. But the tests are happy with the simpler |
|
Yeah, let's do that instead. |
Author
|
Force-pushed the change. |
xiemaisi
approved these changes
Aug 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change whitelists calls with arguments to parameterless functions that trivially throw an exception for the
js/superfluous-trailing-argumentsquery. Such functions are considered placeholders for something else.Example:
The standard evaluations is uneventful. But a run on 200 LGTM projects shows that this change eliminates all of these alerts: https://lgtm.com/query/17012648499980566/?pageIndex=0.
(This change is inspired by the anomaly analysis, I did not open the PR before going on holiday)