docs: add CODEOWNERS entries and rename ql-documentation > language#1722
Merged
felicitymay merged 3 commits intogithub:masterfrom Aug 9, 2019
Merged
docs: add CODEOWNERS entries and rename ql-documentation > language#1722felicitymay merged 3 commits intogithub:masterfrom
ql-documentation > language#1722felicitymay merged 3 commits intogithub:masterfrom
Conversation
Contributor
|
Changes all LGTM. Thanks. |
Contributor
|
@mc - are you happy with this addition of you as a codeowner for JavaScript qhelp files? |
|
no, I am not. (but then I do not know why I am required to be happy. sorry.) |
Contributor
|
Rico Gloeckner, my apologies. I got mixed up between repositories and mentioned entirely the wrong person. I meant to ping @mc-semmle. I'll make sure that I take more care in future. |
Contributor
|
Thanks @jf205, could you also add me as a CODEOWNER for the review of qhelp for COBOL? Thanks. |
Contributor
Author
|
Thanks @mc-semmle. COBOL doesn't live in this repo at the moment. |
Contributor
|
Oh ok, nothing to do then. Thanks 👍 |
mchammer01
approved these changes
Aug 9, 2019
felicitymay
approved these changes
Aug 9, 2019
Contributor
felicitymay
left a comment
felicitymay
left a comment
There was a problem hiding this comment.
The directory rename looks sensible to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a few codeowners entries so that the relevant doc team member is pinged when PRs are created that affect qhelp files for the relevant language. I think I have the added correct github usernames and languages, but please have a quick check.
@felicity-semmle I have also renamed the
ql-documentationfolder tolanguage(as discussed) and added a codeowners entry to notify us for changes in that folder.