C++: Minimal IR support for GNUVectorType
#1750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dave-bartolomeo
force-pushed
the
dave/ZooKeeper
branch
from
be8184d to
a5a20e2
Compare
jbj
previously approved these changes
Aug 20, 2019
cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/Instruction.qll
Show resolved
Hide resolved
Contributor
|
I re-triggered the tests, and they show a semantic merge conflict between this PR and one of the |
Lack of support for the GCC vector extensions was causing a bunch of sanity failures in the syntax zoo. This PR adds minimal IR generation support for these types. Added `VectorAggregateLiteral`, and factored most of `ArrayAggregateLiteral` out into the common base class `ArrayOrVectorAggregateLiteral`. I'd be happy to merge these all into `ArrayAggregateLiteral` if we don't care about the distinction. Made a few tweaks to `TranslatedArrayExpr` to compute the element type by looking at the result type of the `ArrayExpr`, not the type of the base operand. Note that this means that for `T a[10]; a[i] = foo;`, the result of the `PointerAdd` for `a[i]` will now be `glvalue<T>`, not `T*`. This is actually more faithful to the source language, and has no semantic difference on the IR. Added some missing `getInstructionElementSize()` overrides. Added the new `BuiltIn` opcode, renamed the existing `BuiltInInstruction` to `BuiltInOperationInstruction`, and made any `BuiltInOperation` that we don't specifically handle translate to `BuiltIn`. `BuiltInOperationInstruction` now has a way to get the specific `BuiltInOperation`. Added `getCanonicalQLClass()` overrides for `GNUVectorType` and `BuiltInOperation`. Added a simple IR test for vector types.
dave-bartolomeo
force-pushed
the
dave/ZooKeeper
branch
from
a5a20e2 to
a84a7e8
Compare
Contributor
Author
|
Semantic conflicts fixed and ready for merge. |
rdmarsh2
approved these changes
Aug 22, 2019
Contributor
rdmarsh2
left a comment
rdmarsh2
left a comment
There was a problem hiding this comment.
Reapproving after rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lack of support for the GCC vector extensions was causing a bunch of sanity failures in the syntax zoo. This PR adds minimal IR generation support for these types.
Added
VectorAggregateLiteral, and factored most ofArrayAggregateLiteralout into the common base classArrayOrVectorAggregateLiteral. I'd be happy to merge these all intoArrayAggregateLiteralif we don't care about the distinction.Made a few tweaks to
TranslatedArrayExprto compute the element type by looking at the result type of theArrayExpr, not the type of the base operand. Note that this means that forT a[10]; a[i] = foo;, the result of thePointerAddfora[i]will now beglvalue<T>, notT*. This is actually more faithful to the source language, and has no semantic difference on the IR.Added some missing
getInstructionElementSize()overrides.Added the new
BuiltInopcode, renamed the existingBuiltInInstructiontoBuiltInOperationInstruction, and made anyBuiltInOperationthat we don't specifically handle translate toBuiltIn.BuiltInOperationInstructionnow has a way to get the specificBuiltInOperation.Added
getCanonicalQLClass()overrides forGNUVectorTypeandBuiltInOperation.Added a simple IR test for vector types.