Skip to content

Conversation

@geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented Nov 1, 2024

Update models for better Swift 6 compatibility.

This was aimed and fixing some of the test regressions on the Swift 6 PR. I've also tried to fix other cases I found where things we model have changed in Swift 6 (or were simply missing) but it's very likely there are other library changes I have missed.

I haven't removed any older models, since (1) I'm not sure if those models still have value for various reasons and (2) even if they don't, it would require somewhat more verification work to be confident.

@redsun82 let me know if you'd like a change note for these changes specifically. Or will there be a general change note for Swift 6 changes that covers it?

I'll fire off a DCA run as well, though I'm not sure what I expect from it. Also wait to see if CI shows any further tests impacted.

@geoffw0 geoffw0 added the Swift label Nov 1, 2024
@geoffw0 geoffw0 requested a review from a team as a code owner November 1, 2024 16:31
@geoffw0
Copy link
Contributor Author

geoffw0 commented Nov 1, 2024

The BuiltinTypes.ql test failed, because apparently there is now a Builtin.Int128 type. It looks exactly the same on the parent PR, and this is clearly a consequence of the upgrade and not of these changes.

@geoffw0
Copy link
Contributor Author

geoffw0 commented Nov 1, 2024

Nothing to see on the DCA run, apart from analysis time slowdown / wobble.

@redsun82
Copy link
Contributor

redsun82 commented Nov 5, 2024

@redsun82 let me know if you'd like a change note for these changes specifically. Or will there be a general change note for Swift 6 changes that covers it?

I'd say we can do a general change note once we're ready 👍

Copy link
Contributor

@redsun82 redsun82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@redsun82 redsun82 merged commit 87a08fe into github:redsun82/swift-6 Nov 5, 2024
3 of 6 checks passed
@geoffw0 geoffw0 deleted the swift6models branch January 20, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants