Skip to content

JS: additional whitelisting for js/unbound-event-handler-receiver#187

Merged
semmle-qlci merged 4 commits intomasterfrom
unknown repository
Sep 14, 2018
Merged

JS: additional whitelisting for js/unbound-event-handler-receiver#187
semmle-qlci merged 4 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Sep 13, 2018

This PR eliminates a variety of noisy false positives for js/unbound-event-handler-receiver by improving support for bound class methods.

Performance is unchanged for big-apps.slugs.

@ghost ghost added the JS label Sep 13, 2018
@ghost ghost self-requested a review as a code owner September 13, 2018 06:45
Copy link
Contributor

@asger-semmle asger-semmle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@semmle-qlci semmle-qlci merged commit 961ecfb into github:master Sep 14, 2018
aibaars pushed a commit that referenced this pull request Oct 14, 2021
Add rb/hardcoded-credentials query
smowton pushed a commit to smowton/codeql that referenced this pull request Jan 17, 2022
Add todo comment to move property from parameter initialization to co…
MathiasVP pushed a commit to MathiasVP/ql that referenced this pull request Aug 10, 2025
Policy update: Sync-Main Create PR (instead of direct push)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants