-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Rust: Take where clauses into account in path resolution
#19193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hvitved
merged 2 commits into
github:main
from
hvitved:rust/path-resolution-where-clause
Apr 23, 2025
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -547,6 +547,76 @@ mod m23 { | |||||
| } // I108 | ||||||
| } | ||||||
|
|
||||||
| mod m24 { | ||||||
| trait TraitA { | ||||||
| fn trait_a_method(&self); // I110 | ||||||
| } // I111 | ||||||
|
|
||||||
| trait TraitB { | ||||||
| fn trait_b_method(&self); // I112 | ||||||
| } // I113 | ||||||
|
|
||||||
| #[rustfmt::skip] | ||||||
| struct GenericStruct<T> { // I114 | ||||||
| data: T, // $ item=I114 | ||||||
| } // I115 | ||||||
|
|
||||||
| #[rustfmt::skip] | ||||||
| impl<T> // I1151 | ||||||
| GenericStruct<T> // $ item=I115 item=I1151 | ||||||
| where | ||||||
| T: TraitA // $ item=I111 item=I1151 | ||||||
| { | ||||||
| fn call_trait_a(&self) { | ||||||
| self.data.trait_a_method(); // $ item=I110 | ||||||
| } // I116 | ||||||
| } | ||||||
|
|
||||||
| #[rustfmt::skip] | ||||||
| impl<T> // I1161 | ||||||
| GenericStruct<T> // $ item=I115 item=I1161 | ||||||
| where | ||||||
| T: TraitB, // $ item=I113 item=I1161 | ||||||
| T: TraitA, // $ item=I111 item=I1161 | ||||||
| { | ||||||
| fn call_both(&self) { | ||||||
| self.data.trait_a_method(); // $ item=I110 | ||||||
| self.data.trait_b_method(); // $ item=I112 | ||||||
| } // I117 | ||||||
| } | ||||||
|
|
||||||
| struct Implementor; // I118 | ||||||
|
|
||||||
| #[rustfmt::skip] | ||||||
| impl TraitA for Implementor { // $ item=I111 item=I118 | ||||||
| fn trait_a_method(&self) { | ||||||
| println!("TraitA method called"); | ||||||
| } // I119 | ||||||
| } | ||||||
|
|
||||||
| #[rustfmt::skip] | ||||||
| impl TraitB for Implementor { // $ item=I113 item=I118 | ||||||
| fn trait_b_method(&self) { | ||||||
| println!("TraitB method called"); | ||||||
| } // I120 | ||||||
| } | ||||||
|
|
||||||
| #[rustfmt::skip] | ||||||
| pub fn f() { | ||||||
| let impl_obj = Implementor; // $ item=I118 | ||||||
| let generic = GenericStruct { data: impl_obj }; // $ item=I115 | ||||||
|
|
||||||
| generic.call_trait_a(); // $ MISSING: item=I116 | ||||||
|
||||||
| generic.call_trait_a(); // $ MISSING: item=I116 | |
| generic.call_trait_a(); // $ item=I116 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type of
declaringItemis not very descriptive. Any item withresultandthisas descendants would fit. Could we reasonably spell out the type of items we expect here or does this cover to many things that that would be too tedious?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be a bit tedious, type parameters can be declared in many different places: functions, type aliases, structs, enums, unions, consts, traits, impl blocks.