Skip to content

Python: Tweak LoopVariableCapture for performance #19325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joefarebrother merged 1 commit into from
Apr 29, 2025
Merged

Python: Tweak LoopVariableCapture for performance #19325

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/ql/src/Variables/LoopVariableCapture/LoopVariableCaptureQuery.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ module EscapingCaptureFlowConfig implements DataFlow::ConfigSig {
predicate allowImplicitRead(DataFlow::Node node, DataFlow::ContentSet cs) {
isSink(node) and
(
cs instanceof DataFlow::TupleElementContent or
cs.(DataFlow::TupleElementContent).getIndex() in [0 .. 10] or
Copy link
Contributor

@hvitved hvitved Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another way to do this, which doesn't restrict the index, is to properly implement ContentSet, and then have a branch of ContentSet represent all possible TupleElementContents, like e.g. Ruby has a branch that represent all possible element contents.

Copy link
Contributor Author

@joefarebrother joefarebrother Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed; but it seems like it would be quite a significant task to properly implement ContentSet for python.

cs instanceof DataFlow::ListElementContent or
cs instanceof DataFlow::SetElementContent or
cs instanceof DataFlow::DictionaryElementAnyContent
Expand Down