Skip to content

Java: Fix broken performance. #20380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2025
Merged

Java: Fix broken performance. #20380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions java/ql/src/Violations of Best Practice/Naming Conventions/ConfusingOverloading.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ private predicate candidateMethod(RefType t, Method m, string name, int numParam
predicate paramTypePair(Type t1, Type t2) {
exists(Method n, Method m, int i |
overloadedMethodsMostSpecific(n, m) and
t1 = n.getParameterType(i) and
t2 = m.getParameterType(i)
t1 = n.getParameterType(pragma[only_bind_into](i)) and
t2 = m.getParameterType(pragma[only_bind_into](i))
)
}

Expand All @@ -93,6 +93,7 @@ predicate potentiallyConfusingTypesRefTypes(RefType t1, RefType t2) {
}

// then check hasSubtypeOrInstantiation
pragma[nomagic]
predicate potentiallyConfusingTypes(Type t1, Type t2) {
potentiallyConfusingTypesSimple(t1, t2)
or
Expand Down