Skip to content

C#: Deprecate cs/captured-foreach-variable. #20401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelnebel merged 2 commits into from
Sep 11, 2025
Merged

C#: Deprecate cs/captured-foreach-variable. #20401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5da0b9
C#: Deprecate cs/captured-foreach-variable.
michaelnebel Sep 10, 2025
186e42b
C#: Add change note.
michaelnebel Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions csharp/ql/src/Language Abuse/ForeachCapture.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
/**
* @deprecated This query is no longer relevant as the semantics of capturing a 'foreach' variable
* and using it outside the loop has been stable since C# version 5.
* @name Capturing a foreach variable
* @description Code that captures a 'foreach' variable and uses it outside the loop behaves differently in C# version 4 and C# version 5
* @kind problem
Expand Down
4 changes: 4 additions & 0 deletions csharp/ql/src/change-notes/2025-09-10-deprecate-foreach-capture.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: deprecated
---
* The query `cs/captured-foreach-variable` has been deprecated as the semantics of capturing a 'foreach' variable and using it outside the loop has been stable since C# version 5.
Loading