Skip to content

Conversation

@IdrissRio
Copy link
Contributor

@IdrissRio IdrissRio commented Oct 17, 2025

See internal pR

@github-actions github-actions bot added the Java label Oct 17, 2025
@IdrissRio IdrissRio added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Oct 20, 2025
@IdrissRio IdrissRio marked this pull request as ready for review October 20, 2025 06:40
@IdrissRio IdrissRio requested a review from a team as a code owner October 20, 2025 06:40
Copilot AI review requested due to automatic review settings October 20, 2025 06:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an integration test to reproduce a regression related to Maven wrapper projects that are missing properties files. The test sets up a minimal Java project with Maven wrapper scripts but intentionally omits the Maven wrapper properties file to trigger the regression scenario.

  • Creates a new integration test case for Maven wrapper missing properties scenario
  • Sets up a minimal Java "Hello World" project with Maven configuration
  • Includes Maven wrapper scripts (mvnw and mvnw.cmd) without the properties file

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test.py Defines the integration test function that creates a CodeQL database using autobuild mode
Hello.java Simple Java class with main method for the test project
source_archive.expected Expected files to be included in the source archive after database creation
pom.xml Maven project configuration with basic compiler setup
mvnw.cmd Windows Maven wrapper script that handles Maven execution and jar downloading
mvnw Unix/Linux Maven wrapper script with similar functionality to the Windows version

smowton
smowton previously approved these changes Oct 22, 2025
Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test looks sensible. Ideally we would verify mvnw is / isn't used as expected, but the other maven-wrapper tests are similarly just probing for a crash, so there's no immediate need to make that improvement now.

@IdrissRio IdrissRio force-pushed the idrissrio/java-maven-fix branch 2 times, most recently from a9fa4ec to 97f26a4 Compare October 24, 2025 09:56
@IdrissRio IdrissRio force-pushed the idrissrio/java-maven-fix branch from 97f26a4 to 0322197 Compare October 24, 2025 10:56
@IdrissRio IdrissRio force-pushed the idrissrio/java-maven-fix branch from 0322197 to 1b212fd Compare October 27, 2025 12:42
@IdrissRio IdrissRio force-pushed the idrissrio/java-maven-fix branch from 1b212fd to d473b36 Compare October 27, 2025 13:27
@IdrissRio IdrissRio merged commit 11a7d53 into main Oct 27, 2025
8 of 13 checks passed
@IdrissRio IdrissRio deleted the idrissrio/java-maven-fix branch October 27, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

depends on internal PR This PR should only be merged in sync with an internal Semmle PR Java

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants