Skip to content

Dataflow: Minor drive-by qldoc addition. #20713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2025
Merged

Dataflow: Minor drive-by qldoc addition. #20713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,13 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {

predicate returnMayFlowThrough(RetNd ret, ReturnKindExt kind);

/**
* Holds if this stage makes use of a store step of content `c` from
* `node1` to `node2`.
*
* `contentType` and `containerType` are the types of the content being
* stored, and the type of the resulting container, respectively.
*/
predicate storeStepCand(Nd node1, Content c, Nd node2, Type contentType, Type containerType);

predicate readStepCand(Nd n1, Content c, Nd n2);
Expand Down Expand Up @@ -486,6 +493,14 @@ module MakeImpl<LocationSig Location, InputSig<Location> Lang> {
)
}

/**
* Holds if a node with type `containerType` is compatible with an
* access path with head content `apc`. This is determined by checking
* type compatibility against the possible types of nodes that are
* targets of store steps with content `apc`.
*
* Excludes the case where `apc` is compatible with all types.
*/
bindingset[apc, containerType]
pragma[inline_late]
private predicate compatibleContainer(ApHeadContent apc, Type containerType) {
Expand Down
Loading