Actions: don't fail if no JS/TS code was found #20752
Merged
+14
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for detecting when the Actions extractor is being used and adjusts the extraction failure logic accordingly. The key change allows the extractor to succeed even when no JavaScript/TypeScript code is found if running in Actions extractor mode.
- Added a new environment variable
CODEQL_EXTRACTOR_ACTIONS_WIP_DATABASEand helper method to detect Actions extractor mode - Modified the extraction failure condition to allow success without code when using the Actions extractor
- Fixed comment typos in the extraction logic
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| EnvironmentVariables.java | Added constant for Actions extractor environment variable and isActionsExtractor() helper method |
| AutoBuild.java | Updated extraction failure condition to allow Actions extractor to succeed without code, and fixed comment typos |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
javascript/extractor/src/com/semmle/js/extractor/AutoBuild.java
Outdated
Show resolved
Hide resolved
javascript/extractor/src/com/semmle/js/extractor/AutoBuild.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
The code was written on the assumption that 'seenCode' implies 'seenFiles' but the unit test override 'hasSeenCode()' to always return true. Which meant we would start taking this branch in the unit tests.
mbg
approved these changes
Nov 4, 2025
mbg
pushed a commit
that referenced
this pull request
Nov 4, 2025
Actions: don't fail if no JS/TS code was found
mbg
added a commit
that referenced
this pull request
Nov 4, 2025
…f-no-js Backport: Merge pull request #20752 from asgerf/actions/dont-fail-if-no-js
This was referenced Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.