Skip to content

Conversation

@jketema
Copy link
Contributor

@jketema jketema commented Nov 4, 2025

Also document that we need to update the supported versions, so we don't forget it next time around.

Also document that we need to update the supported versions, so we don't forget
it next time around.
@jketema jketema requested a review from a team as a code owner November 4, 2025 14:58
Copilot AI review requested due to automatic review settings November 4, 2025 14:58
@jketema jketema requested a review from a team as a code owner November 4, 2025 14:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the documentation to reflect support for Swift 6.2 and adds a new step in the Swift update process documentation.

  • Updated supported Swift versions from 5.4-6.1 to 5.4-6.2
  • Added a new step in the updating guide to remind maintainers to update the supported versions documentation for non-patch updates

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
swift/third_party/resources/updating.md Added step 10 to remind maintainers to update supported versions documentation for non-patch updates
docs/codeql/reusables/supported-versions-compilers.rst Updated Swift version support from 6.1 to 6.2

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

@IdrissRio IdrissRio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 I left a small suggestion, totally up to you.

8. Clear `_override` in [`load.bzl`](../load.bzl).
9. Add a change note to the [library change note directory](../../ql/lib/change-notes/) that mentions that we now support the Swift version we updated to.
10. If this not patch update, then update the [supported versions](../../../docs/codeql/reusables/supported-versions-compilers.rst) with the Swift version we updated to.
10. If this is not a patch update, then update the [supported versions](../../../docs/codeql/reusables/supported-versions-compilers.rst) with the Swift version we updated to.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rephrase point number 10 slightly:

If this is not a patch update, update the supported versions to match the Swift version we upgraded to.

@jketema jketema merged commit 5d9d6b9 into github:main Nov 5, 2025
12 checks passed
@jketema jketema deleted the swift-doc-update branch November 5, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants