Skip to content

javascript: Add support for document.defaultView in global variable references #20844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 27, 2025
Merged

javascript: Add support for document.defaultView in global variable references #20844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
30cc914
javascript: Add support for `document.defaultView` in global variable…
Eliav2 Nov 16, 2025
bd18e86
javascript: add change note
Eliav2 Nov 16, 2025
8047450
javascript: Update property access for `document.defaultView as getAP…
Eliav2 Nov 16, 2025
08dfb95
javascript: Add change note for `document.defaultView` aliasing `window`
Eliav2 Nov 19, 2025
91451b7
javascript: Update expected results for global variable references
Eliav2 Nov 20, 2025
6df789d
Merge branch 'main' into 20823-globalVarRef-document-defaultView
Eliav2 Nov 20, 2025
192f254
Merge branch 'main' into 20823-globalVarRef-document-defaultView
Eliav2 Nov 23, 2025
69ba764
Merge branch 'main' into 20823-globalVarRef-document-defaultView
Eliav2 Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions javascript/ql/lib/change-notes/2025-11-19-default-view.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
category: minorAnalysis
---

- JavaScript `DataFlow::globalVarRef` now recognizes `document.defaultView` as an alias of `window`, allowing flows such as `document.defaultView.history.pushState(...)` to be modeled and found by queries relying on `globalVarRef("history")`.
Copy link
Contributor

@asgerf asgerf Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I overlooked that this change note is in the wrong file. Files in the released directory are auto-generated during the release process.

Could you move this one directory up and rename it to 2025-11-19-default-view.md, and replace the headings with the preamble:

---
category: minorAnalysis
---

Copy link
Contributor Author

@Eliav2 Eliav2 Nov 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, no problem, done, moved to lib/change-notes/2025-11-19-default-view.md ****

3 changes: 3 additions & 0 deletions javascript/ql/lib/semmle/javascript/dataflow/Nodes.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,6 +393,9 @@ DataFlow::SourceNode globalObjectRef() {
// DOM
result = globalVariable("window")
or
// DOM alias via `document.defaultView`
result = globalVariable("document").getAPropertyRead("defaultView")
or
// Node.js
result = globalVariable("global")
or
Expand Down
3 changes: 3 additions & 0 deletions javascript/ql/test/library-tests/Nodes/globalObjectRef.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,12 @@
| tst2.js:8:1:8:6 | global |
| tst3.js:1:1:1:0 | this |
| tst3.js:3:9:3:19 | goog.global |
| tst4.js:1:1:1:0 | this |
| tst4.js:1:1:1:38 | require ... ultView |
| tst.js:1:1:1:0 | this |
| tst.js:1:1:1:6 | window |
| tst.js:3:1:3:6 | window |
| tst.js:4:1:4:6 | window |
| tst.js:5:1:5:4 | self |
| tst.js:6:1:6:10 | globalThis |
| tst.js:7:1:7:20 | document.defaultView |
4 changes: 4 additions & 0 deletions javascript/ql/test/library-tests/Nodes/globalVarRef.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,19 @@
| Object | tst2.js:8:1:8:13 | global.Object |
| String | tst2.js:9:1:9:11 | this.String |
| document | tst2.js:2:1:2:26 | require ... ument") |
| document | tst4.js:1:1:1:26 | require ... ument") |
| document | tst.js:3:1:3:15 | window.document |
| document | tst.js:5:1:5:13 | self.document |
| document | tst.js:6:1:6:19 | globalThis.document |
| document | tst.js:7:1:7:8 | document |
| foo | tst3.js:4:1:4:5 | w.foo |
| global | tst2.js:7:1:7:6 | global |
| global | tst2.js:8:1:8:6 | global |
| globalThis | tst.js:6:1:6:10 | globalThis |
| goog | tst3.js:1:1:1:4 | goog |
| goog | tst3.js:3:9:3:12 | goog |
| history | tst4.js:1:1:1:46 | require ... history |
| history | tst.js:7:1:7:28 | documen ... history |
| self | tst.js:5:1:5:4 | self |
| setTimeout | tst2.js:5:1:5:12 | g.setTimeout |
| window | tst2.js:3:1:3:24 | require ... indow") |
Expand Down
1 change: 1 addition & 0 deletions javascript/ql/test/library-tests/Nodes/tst.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ window.document;
window.window.document;
self.document;
globalThis.document;
document.defaultView.history;
1 change: 1 addition & 0 deletions javascript/ql/test/library-tests/Nodes/tst4.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
require("global/document").defaultView.history;