Skip to content

Conversation

@michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Nov 28, 2025

In this PR

  • Disable the .NET 10 tests (as they appear to be failing after .NET 10 has been installed on the MacOS runners).
  • Pin tests to 9.0.304.

@github-actions github-actions bot added the C# label Nov 28, 2025
@michaelnebel michaelnebel marked this pull request as ready for review November 28, 2025 13:55
@michaelnebel michaelnebel requested a review from a team as a code owner November 28, 2025 13:55
Copilot AI review requested due to automatic review settings November 28, 2025 13:55
@michaelnebel michaelnebel requested a review from mbg November 28, 2025 13:56
Copilot finished reviewing on behalf of michaelnebel November 28, 2025 13:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses test stability issues with .NET 10 on MacOS runners by skipping affected tests and pinning SDK versions to prevent version-related failures across the C# integration test suite.

  • Skip .NET 10 integration tests due to crashes in the info command
  • Pin test SDK versions to 9.0.304 for consistency across multiple test suites
  • Pin blazor_net_8 test to SDK version 8.0.401

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
csharp/ql/integration-tests/all-platforms/dotnet_10/test.py Adds pytest skip decorators to disable both .NET 10 tests
csharp/ql/integration-tests/posix/standalone_dependencies_nuget_config_fallback/global.json Pins SDK to version 9.0.304
csharp/ql/integration-tests/posix/standalone_dependencies_nuget_config_error_timeout/global.json Pins SDK to version 9.0.304
csharp/ql/integration-tests/all-platforms/standalone_failed/global.json Pins SDK to version 9.0.304
csharp/ql/integration-tests/all-platforms/blazor_net_8/global.json Pins SDK to version 8.0.401 for .NET 8 compatibility
csharp/ql/integration-tests/all-platforms/blazor_build_mode_none/global.json Pins SDK to version 9.0.304
csharp/ql/integration-tests/all-platforms/blazor/global.json Pins SDK to version 9.0.304

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Comment on lines +3 to +7
@pytest.mark.skip(reason=".NET 10 info command crashes")
def test1(codeql, csharp):
codeql.database.create()

@pytest.mark.skip(reason=".NET 10 info command crashes")
Copy link

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description states tests should be "marked as flaky", but the implementation uses @pytest.mark.skip which completely disables the tests. Consider using @pytest.mark.xfail instead if you want to mark them as expected to fail while still running them, or update the PR description to clarify that the tests are being skipped/disabled rather than marked as flaky.

Suggested change
@pytest.mark.skip(reason=".NET 10 info command crashes")
def test1(codeql, csharp):
codeql.database.create()
@pytest.mark.skip(reason=".NET 10 info command crashes")
@pytest.mark.xfail(reason=".NET 10 info command crashes")
def test1(codeql, csharp):
codeql.database.create()
@pytest.mark.xfail(reason=".NET 10 info command crashes")

Copilot uses AI. Check for mistakes.
@michaelnebel michaelnebel changed the title C#: Pin tests and mark .NET 10 tests as flaky. C#: Pin tests and disable .NET 10 tests. Nov 28, 2025
@michaelnebel michaelnebel merged commit 1d56f17 into github:main Nov 28, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants