Java: Data-flow pruning based on call contexts.#2099
Merged
hvitved merged 20 commits intogithub:masterfrom Oct 15, 2019
Merged
Conversation
…all context is not used to prune branches.
…ntext.
We now detect patterns like
f(bool cond){
if(cond)
then A
else B
and prune branches for calls like f(true) or f(false).
This pruning is done both in the local (bigstep) flow graph
as well as in the inter-procedural dataflow graph.
Contributor
Author
|
Changes on https://jenkins.internal.semmle.com/job/Changes/job/Java-Differences/337/ looks good (I accidentally switched the shas, so the removed results are listed as added). Two FPs removed on jdk11. |
hvitved
reviewed
Oct 14, 2019
Contributor
hvitved
left a comment
hvitved
left a comment
There was a problem hiding this comment.
LGTM, just a few minor comments.
| * Gets the local call context given the call context and the callable that | ||
| * the contexts apply to. | ||
| */ | ||
| LocalCallContext getLocalCallContext(CallContext ctx, DataFlowCallable callable) { |
Contributor
There was a problem hiding this comment.
Do you think it makes sense to cache this predicate?
Contributor
Author
There was a problem hiding this comment.
It might. I don't think it's crucial, though.
| ) | ||
| } | ||
|
|
||
| /** An expression that always has the same boolean value. */ |
Contributor
There was a problem hiding this comment.
An expression -> A call argument
Contributor
There was a problem hiding this comment.
boolean -> Boolean (also below)
hvitved
approved these changes
Oct 14, 2019
yh-semmle
approved these changes
Oct 15, 2019
This was referenced Oct 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of #2011.