Rust: Accept changes to expected files #20997
Merged
+7
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paldepind
force-pushed
the
rust/fix-expected
branch
from
65006d8 to
53ad328
Compare
hvitved
approved these changes
Dec 9, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR accepts updated expected test output files for Rust CodeQL tests, reflecting changes in query behavior or test results.
- Removes dataflow entries related to specific lifetime analysis scenarios (lines 841 and 851 in lifetime.rs)
- Adds recognition of the multiplication operator (
mul) as a viable callable and taint propagator - Updates model and edge references to reflect the new dataflow behavior
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rust/ql/test/query-tests/security/CWE-825/AccessAfterLifetime.expected | Removes dataflow edges and nodes for specific lifetime scenarios, indicating refined lifetime analysis |
| rust/ql/test/library-tests/dataflow/global/viableCallable.expected | Adds the mul operator as a recognized viable callable for dataflow analysis |
| rust/ql/test/library-tests/dataflow/global/inline-flow.expected | Updates dataflow models, edges, and nodes to include taint propagation through the multiplication operator |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.