Conversation
|
I've just created raulgarciamsft#5 to autoformat the QL code in this PR. |
cpp/ql/test/query-tests/Likely Bugs/Protocols/boostorg/asio/boost_simulation.hpp
Outdated
Show resolved
Hide resolved
|
Pushed autoformat. |
geoffw0
left a comment
geoffw0
left a comment
There was a problem hiding this comment.
I'm happy with this PR and want to see it merged now. However since I contributed by direct pushes (that have not been reviewed by someone else), I'd like someone else to check they're happy with those and hit merge.
jbj
left a comment
jbj
left a comment
There was a problem hiding this comment.
I've triggered the PR checks. I'm happy to merge this PR if they pass.
| "qhelp.dtd"> | ||
| <qhelp> | ||
| <overview> | ||
| <p>Using TLS or SSLv23 protool from the boost::asio library, but not disabling deprecated protocols or disabling minimum-recommended protocols.</p> |
There was a problem hiding this comment.
protool > protocol
Add "the" before "SSLv23"
There was a problem hiding this comment.
"but not disabling deprecated protocols or disabling minimum-recommended protocols"
to avoid this being read as:
!(disabling deprecated protocols || disabling minimum-recommended protocols)
add a comma:
"but not disabling deprecated protocols, or disabling minimum-recommended protocols"
There was a problem hiding this comment.
This feels like it's missing the conclusion of the sentence:
"Using TLS or the SSLv23 protocol ... causes X."
or: "Using TLS or the SSLv23 protocol ... is bad because ..."
4 participants
Adding queries for boost.org TLS usage