C#: Fix CSRF query to check antiforgery attributes on base classes #21265
+70
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a change note documenting a fix to the C# CSRF query so it recognizes antiforgery attributes inherited from base controller classes.
Changes:
- Added a change note entry for
cs/web/missing-token-validationdescribing reduced false positives when antiforgery attributes are applied on parent classes.
| --- | ||
| category: fix | ||
| --- | ||
| * The `cs/web/missing-token-validation` ("Missing cross-site request forgery token validation") query now recognizes antiforgery attributes on base controller classes, fixing false positives when `[ValidateAntiForgeryToken]` or `[AutoValidateAntiforgeryToken]` is applied to a parent class. |
There was a problem hiding this comment.
The PR title/description indicate a functional fix to the cs/web/missing-token-validation query, but the diff shown here only adds a change note. If the query update is part of this PR, please include it in the changes; otherwise the change note will be inaccurate.
hvitved
approved these changes
Feb 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21255