Python: Fix cyclic import FP relating to packages. #2147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RasmusWL
requested changes
Oct 22, 2019
Member
RasmusWL
left a comment
RasmusWL
left a comment
There was a problem hiding this comment.
Looks plausible to me 😉
Could you add the test-case we talked about with
from bar.foo import foo
import baz
p = 1
that didn't seem to work when running through python?
taus-semmle
force-pushed
the
python-cyclic-import-package-fp
branch
from
f0c5317 to
32de65c
Compare
Contributor
|
Done. |
RasmusWL
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2125.
I also added a test case for one (of the many) instances that appeared on LGTM.com.