Avoid caching unresolveElement.
#215
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavgust
force-pushed
the
imp/unresolve-element
branch
2 times, most recently
from
982cb87 to
403bae8
Compare
The `resolveClass` part of its definition is not functional, but the rest is. If we do not cache it but eagerly inline it, there are more cases where we can use that functionality to generate better code.
pavgust
force-pushed
the
imp/unresolve-element
branch
from
403bae8 to
c34114e
Compare
|
I'm benchmarking this PR with our LGTM suite on Wireshark. Preliminary results show that this branch prevents timeouts on four queries, slows down most other queries slightly, and slows down |
|
I'm benchmarking on Wireshark, by the way. |
|
@adityasharad @aibaars: only one (or none) of #232 and #215 should be merged, and we're still testing to find out what it should be. |
|
Closing, as #232 went in. |
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Feb 7, 2022
Kotlin: Make an unnecessarily-optional argument a required argument
MathiasVP
pushed a commit
to MathiasVP/ql
that referenced
this pull request
Aug 10, 2025
PS: Add SQL injection query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
resolveClasspart of its definition is not functional, but therest is. If we do not cache it but eagerly inline it, there are more
cases where we can use that functionality to generate better code.