C++: buffer read side effects on unmodeled funcs#2150
Merged
dbartol merged 4 commits intogithub:masterfrom Oct 31, 2019
Merged
Conversation
dbartol
reviewed
Oct 29, 2019
dbartol
left a comment
dbartol
left a comment
There was a problem hiding this comment.
Otherwise LGTM, pending merge conflict resolution.
| not result instanceof DerivedType and | ||
| operandTag instanceof SideEffectOperandTag | ||
| if hasSpecificReadSideEffect(any(Opcode::BufferReadSideEffect op)) | ||
| then result instanceof UnknownType |
There was a problem hiding this comment.
Don't you need to bind tag and operandTag in the then branch as well?
added 2 commits
October 30, 2019 14:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.