C++: Expose indirect instructions and indirect parameters in dataflow#21552
Merged
MathiasVP merged 5 commits intogithub:mainfrom Mar 23, 2026
Merged
C++: Expose indirect instructions and indirect parameters in dataflow#21552MathiasVP merged 5 commits intogithub:mainfrom
MathiasVP merged 5 commits intogithub:mainfrom
Conversation
jketema
previously approved these changes
Mar 23, 2026
Contributor
jketema
left a comment
jketema
left a comment
There was a problem hiding this comment.
LGTM. Maybe run some DCA just to be on the safe side.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the public C/C++ IR dataflow API to make common internal dataflow concepts available to query authors, specifically indirect instructions and indirect parameter nodes.
Changes:
- Expose
IndirectParameterNodein the publicDataFlowNodesAPI. - Add
DataFlow::Node.asIndirectInstruction(int index)to mirror existing indirect-operand support.
Contributor
Author
Thanks for the quick approval. Will do. I'm still writing the change note and I'll start a DCA once I've pushed that |
jketema
approved these changes
Mar 23, 2026
Contributor
Author
|
DCA was uneventful (as expected). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes two concepts that we use all the time internally in C/C++ dataflow to the public API:
IndirectParameterNodeto the public API. Right now, it's impossible to select the indirection of a parameter as a dataflow node in queries.asIndirectInstructionpredicate toDataFlow::Nodesimilar to how we haveasIndirectOperand. Temporarily adding this predicate is quite a common thing for me to do locally when I write queries, and we might as well make this available to everyone else to match what we have for indirect operands.