Skip to content

C++: Upgrade cpp/wrong-type-format-argument to high precision#21632

Merged
geoffw0 merged 3 commits intogithub:mainfrom
geoffw0:wrongtype2
Apr 10, 2026
Merged

C++: Upgrade cpp/wrong-type-format-argument to high precision#21632
geoffw0 merged 3 commits intogithub:mainfrom
geoffw0:wrongtype2

Conversation

@geoffw0
Copy link
Copy Markdown
Contributor

@geoffw0 geoffw0 commented Apr 2, 2026

Upgrade cpp/wrong-type-format-argument to @precision high (following improvement and multiple rounds of testing).

@geoffw0
Copy link
Copy Markdown
Contributor Author

geoffw0 commented Apr 10, 2026

DCA, QA LGTM. Bringing out of draft.

@geoffw0 geoffw0 marked this pull request as ready for review April 10, 2026 12:55
@geoffw0 geoffw0 requested a review from a team as a code owner April 10, 2026 12:55
Copilot AI review requested due to automatic review settings April 10, 2026 12:55
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the CodeQL C++ query cpp/wrong-type-format-argument to high precision, which causes it to be included in the default C++ code scanning suite, and records the change in release notes.

Changes:

  • Updated cpp/wrong-type-format-argument query metadata to @precision high.
  • Added a change note documenting the precision upgrade and suite impact.
  • Updated the code scanning query-suite integration-test expectation to include the query.
Show a summary per file
File Description
cpp/ql/src/Likely Bugs/Format/WrongTypeFormatArguments.ql Bumps query precision metadata from medium to high.
cpp/ql/src/change-notes/2026-04-02-wrong-type-format-argument.md Documents the precision upgrade in change notes.
cpp/ql/integration-tests/query-suite/cpp-code-scanning.qls.expected Updates expected expanded suite contents to include the query.

Copilot's findings

  • Files reviewed: 3/3 changed files
  • Comments generated: 0

@geoffw0
Copy link
Copy Markdown
Contributor Author

geoffw0 commented Apr 10, 2026

Thanks for the quick reviews!

@geoffw0 geoffw0 merged commit 814c0ae into github:main Apr 10, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants