Add tests for multiple Git sources and GoProxy servers in registry config parsing#21639
Merged
mario-campos merged 1 commit intomainfrom Apr 2, 2026
Merged
Add tests for multiple Git sources and GoProxy servers in registry config parsing#21639mario-campos merged 1 commit intomainfrom
mario-campos merged 1 commit intomainfrom
Conversation
mbg
approved these changes
Apr 2, 2026
Member
mbg
left a comment
mbg
left a comment
There was a problem hiding this comment.
This looks ok to me, thanks! Bit disappointing that I only added tests for parsing the configs and not the further processing / environment variable construction that makes up the bulk of the work for this in the Go extractor. It would probably require some refactoring to make that code testable, so it's probably outside the scope of this work to add tests for that (unless you really want to in a separate PR).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two additional tests to the Go extractor's test suite. The two new tests verify that a registry configuration with two identical registry-types (
(git_source, git_source)and(goproxy_server, goproxy_server)) can be parsed.