Actions: Adjust alert location UntrustedCheckoutCritical#21800
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the actions/untrusted-checkout/critical query so its main alert location points at the checkout step rather than the later poisonable step, bringing it closer to the related untrusted-checkout queries and documenting the resulting alert churn.
Changes:
- Changed the critical untrusted-checkout query selection to use the checkout step as the alert’s main location.
- Regenerated the expected test output to reflect the new alert locations.
- Added a change note explaining the location shift and the expected close/reopen behavior for existing alerts.
Show a summary per file
| File | Description |
|---|---|
actions/ql/src/Security/CWE-829/UntrustedCheckoutCritical.ql |
Adjusts the selected alert location in the critical query. |
actions/ql/test/query-tests/Security/CWE-829/UntrustedCheckoutCritical.expected |
Updates golden test output for the new alert locations. |
actions/ql/src/change-notes/2026-05-05-untrusted-checkout-high.md |
Adds a user-facing change note for the alert-location update. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 1
| --- | ||
| category: majorAnalysis | ||
| --- | ||
| * Adjusted `actions/untrusted-checkout/critical` to align more with other untrusted resource queries, where the alert location is the location where the artifact is obtained from (the checkout point). This aligns with the other 2 related queries. This will cause the same alerts to re-open for closed alerts of this query. No newline at end of file |
There was a problem hiding this comment.
copilot is right, but the fix is wrong. Also, the filename doesn't matter, so I wouldn't bother changing it.
owen-mc
left a comment
owen-mc
left a comment
There was a problem hiding this comment.
Changing alert locations causes alert churn (alerts that have been dismissed are re-opened), so we try to keep it to a minimum. In this case we have checked how many dismissed alerts will be re-opened and determined that the trade-off is worth it to have consistency between the three queries in future.
owen-mc
changed the title
this change will result in alerts closing and reopening
but has the benefit of allowing the query main location to align better with other queries of this type